cytomining / profiling-recipe

Image-based Profiling Recipe
BSD 3-Clause "New" or "Revised" License
8 stars 26 forks source link

First draft of subgroup normalization #39

Open bethac07 opened 1 year ago

bethac07 commented 1 year ago

Might be made unnecessary by https://github.com/cytomining/pycytominer/issues/154, but that's TBD. @ErinWeisbart, can you test when you get to the profiles stage of the cell painting project you just started? LMK if the implementation isn't self-evident in what you'd do to change the metadata and/or the actual config file you run.

ErinWeisbart commented 1 year ago

Worked for me.

Minor suggestion:

Bigger request:

ErinWeisbart commented 1 year ago

I went ahead and wrote the "Bigger Request" because I wanted it for the batch I was processing. Now, it will always have default behavior but if you set subgroup: true in normalize it will also output subgroup_normalized files. Additionally, if you set subgroup: true for feature_select it will output the default as well as subgroup_normalized_feature_selected

I have tested it on the one batch I was processing but have not otherwise done extensive testing.

ErinWeisbart commented 1 year ago

We discussed today that we want to abstract the subgroup further and create a separate option normalize_subgroup similar to how normalize_negcon is separate from normalize.