cytopia / devilbox

A modern Docker LAMP stack and MEAN stack for local development
http://devilbox.org
MIT License
4.4k stars 654 forks source link

mysqldump-secure: documentation and multi-php fix. #995

Open userwiths opened 1 year ago

userwiths commented 1 year ago

Fixes for issue #985

PR contains two commits, one only for documentation, one for yml fix, both are related to the same issue.

Goal

Improve documentation and prevent future misunderstandings due to the user being unaware of certain variables. Add missing mounts for the multi PHP setup.

Description

Documentation Commit

The following variables:

Are used for generating the mysqldump-secure configuration file as can be seen here In case they are missing from the .env file, the mysqldump-secure command cannot be run successfully on containers other than the default one due to different username/password.

Multi PHP issue

Here the issue was that the backups directory was not mounting to the given container, probably because of the missing declaration. Was added and tested, now mysqldump-secure should be able to write to the host directory regardless from which container it is started.