search

cytopia / docker-ansible-lint

Alpine-based multistage-build version of ansible-lint for reproducible usage in CI
MIT License
16 stars 9 forks source link

update to alpine:3.18 #37

Open tomkuba opened 1 year ago

tomkuba commented 1 year ago

fix https://github.com/cytopia/docker-ansible-lint/issues/36

error does not happen with alpine 3.18 as it does not contain conflicting version of "packaging" package.

tomkuba commented 1 year ago

@cytopia can you please take a look?

rwaffen commented 1 year ago

bump, would be nice to have this

rwaffen commented 1 year ago

@tomkuba looking at the code, shouldn't you also update the version in the finale image in line 33?

tomkuba commented 1 year ago

@tomkuba looking at the code, shouldn't you also update the version in the finale image in line 33?

Yes, I messed up. Thanks

fhirscher commented 1 year ago

@tomkuba In Alpine 3.18, Python is shipped with version 3.11. Therefore, line 58 must also be updated. from: COPY --from=builder /usr/lib/python3.10/site-packages/ /usr/lib/python3.10/site-packages/ to: COPY --from=builder /usr/lib/python3.11/site-packages/ /usr/lib/python3.11/site-packages/

Omjoa001 commented 8 months ago

This worked for me, thanks a ton!