Allow Overriding of NS Records on subdomains

cytopia / terraform-aws-route53-zone

A Terraform module that handles creation of multiple Route53 zones including attachment to new or existing delegation set

MIT License

14 stars 18 forks source link

Closed timothyclarke closed 4 years ago

timothyclarke commented 5 years ago

Fixes the following error (using terraform 11.14)

` module.route53-zone.aws_route53_record.undelegated_subdomains_ns_default[0]: 1 error occurred:

aws_route53_record.undelegated_subdomains_ns_default.0: [ERR]: Error building changeset: InvalidChangeBatch: [Tried to create resource record set [name='dev.example.com.', type='NS'] but it already exists] status code: 400, request id:`

cytopia commented 4 years ago

@timothyclarke thanks for the PR. Can you please run terraform fmt on your code in order to address the CI issues.

cytopia commented 4 years ago

@timothyclarke this will be taken care of here (for TF 0.12) https://github.com/cytopia/terraform-aws-route53-zone/pull/8

timothyclarke commented 4 years ago

@cytopia Sorry I missed the comment on 4th November. I've only just received your latest comment