cytoscape / RCy3

New version of RCy3, redesigned and collaboratively maintained by Cytoscape developer community
MIT License
48 stars 20 forks source link

Looping checks rather than fixed delays #101

Closed AlexanderPico closed 3 years ago

AlexanderPico commented 3 years ago

Per Barry's suggestion, we could check for certain events or changes to complete before proceeding instead of relying on the hard-coded delays which are not optimized per use case.

Might borrow ideas from here to construct the looping checks: http://bioconductor.org/developers/how-to/web-query/

AlexanderPico commented 3 years ago

Might also include setters for the delay values, like Barry did for py4cy:

def set_catchup_filter_secs(delay_secs):
    CATCHUP_FILTER_SECS = delay_secs

def set_model_propagation_secs(delay_secs):
    MODEL_PROPAGATION_SECS = delay_secs

def set_catchup_network_secs(delay_secs):
    CATCHUP_NETWORK_SECS = delay_secs

def set_ndex_delay_secs(delay_secs):
    NDEX_DELAY_SECS = delay_secs
bdemchak commented 3 years ago

Looping checks rather than fixed delays #101

AlexanderPico commented 3 years ago

Removed NDEx delays (like in py4cy) and added setter methods in RCy3.R using custom package environment, RCy3env.