search

cytoscape / RCy3

New version of RCy3, redesigned and collaboratively maintained by Cytoscape developer community
MIT License
50 stars 20 forks source link

.edgeNameToEdgeSUID returns SUIDS in a different order than input names #115

Closed AlexanderPico closed 3 years ago

AlexanderPico commented 3 years ago

The returned set of SUIDs is assumed to be in the same order as the input names. I believe this used to be the case when these methods were first implemented and tested, but perhaps a change in CyREST or Cytoscape responsible.

In any case, this and related functions need to be updated to faithfully return in the assumed order.

AlexanderPico commented 3 years ago

Nope. This commit in response to #41 is the culprit! https://github.com/cytoscape/RCy3/commit/053246a6acdfbf8f0536f2cf00b34b4efc64ee79

AlexanderPico commented 3 years ago

Need a solution that preserves order and addresses multigraphs...

AlexanderPico commented 3 years ago

Applied solution to both .edgeNameToEdgeSUID and .nodeNameToNodeSUID to handle cases where folks are supplying edge/node name lists that intentionally contain duplicates, i.e., repeated nodes and multigraphs.