search

cytoscape / RCy3

New version of RCy3, redesigned and collaboratively maintained by Cytoscape developer community
MIT License
50 stars 20 forks source link

Possible failure in deleteDuplicateEdges() and addCyEdges() #129

Closed bdemchak closed 3 years ago

bdemchak commented 3 years ago

The newest versions of edgeNameToEdgeSuid() and nodeNameToNameSuid() appear to assume the list parameter contains items intended to be unique. In cases like deleteDuplicateEdges() and addCyEdges(), this is not true, and the original versions of edgeNameToEdgeSuid() and nodeNameToNameSuid() seem to be appropriate.

I am extrapolating this from the analogous changes in py4cytoscape 0.0.9 and execution of the larger test suite. If I'm right, please see the 0.0.9 edgeNameToEdgeSuid() and nodeNameToNameSuid() implementations and adjust callers to have the unique_list= parameter where appropriate.