isolate setVisualStyle need for sleep in unit test

cytoscape / RCy3

New version of RCy3, redesigned and collaboratively maintained by Cytoscape developer community

MIT License

50 stars 20 forks source link

isolate setVisualStyle need for sleep in unit test #140

Closed AlexanderPico closed 3 years ago

AlexanderPico commented 3 years ago

Obs: exportImage after setVisualStyle does not reflect new style

Maybe test by grabbing style value after setVisualStyle?

Share test with py4cy

AlexanderPico commented 3 years ago

This test fails if MODEL_PROP_SECS is < 1.

library(RCy3)
openSession()
setModelPropagationSecs(0)
setVisualStyle("default")
exportImage("galFiltered_or_default")

I can not reproduce the need for sleep for getCurrentStyle() or and property value gets (which depend on specifying the current style), so this one is hard to unit test.

AlexanderPico commented 3 years ago

Mike fixed this in CyREST: https://github.com/cytoscape/cyREST/commit/8b53dd13dce42f12d8b2f8e7f5b0e0b385c5d1f9