search

cytoscape / RCy3

New version of RCy3, redesigned and collaboratively maintained by Cytoscape developer community
MIT License
48 stars 20 forks source link

Conflicting Brightness/Contrast documentation #172

Closed bdemchak closed 2 years ago

bdemchak commented 2 years ago

The documentation for addAnnotationImage indicates that brightness and contrast values have range 0..100, but the RCy3-utils.checkBrightnessContrast uses -100..100. Which is correct?

AlexanderPico commented 2 years ago

It's 0 to 100. I was just being lazy and reusing a check we already had in utils for other functions. It all works, but indeed gives the (wrong) impression that values between -100 and 0 will be different... and they are not in this case.

bdemchak commented 2 years ago

Not so sure about this. If I use the Cytoscape GUI to insert an annotation image, I see the sliders for contrast and brightness running -100..100.

Would you take another look at this? If they really should be 0..100, I'll need to file a Cytoscape bug report.

Or am I not seeing this right?

AlexanderPico commented 2 years ago

I just added an image with -100 and 0 and they looked the same. That's all I know. Scooter might know how it actually works.

AlexanderPico commented 2 years ago

I was wrong. Reverting back to original code and updating man pages.