search

cytoscape / RCy3

New version of RCy3, redesigned and collaboratively maintained by Cytoscape developer community
MIT License
49 stars 20 forks source link

updateAnnotationText cleanup #177

Closed bdemchak closed 2 years ago

bdemchak commented 2 years ago

If an annotationName isn't provided, an error is returned, which seems right. However, the error ("Must provide the UUID (or list of UUIDs) to group") implies that a list of UUIDs is acceptable, and it mentions a group. From what I can tell in the Commands Dialog help and the function documentation, this should be either an annotation name or a UUID, and there is no list or group involved. What's the real situation, and is the error text in this function correct?

The same comment applies to other update functions.

There is a check to make sure the text string is non-Null ... Is it really necessary that the caller set the text string when updating? I think this may be necessary only when adding?

bdemchak commented 2 years ago

Thanks. I concur and have made similar changes in py4cytoscape.