suggestion: selectEdgesAdjacentToSelectedNodes ; add nodes in function so we don't have to run selected nodes just before

[veroniquevoisin]

just a suggestion in case it helps: selectEdgesAdjacentToSelectedNodes ; add nodes in function so we don't have to run selected nodes just before)

current

Selectednodes = selectNodes( nodes = unlist(drugnetwork1$V1), by.col = "name", preserve.current.selection = TRUE, network = "network1", base.url = "http://localhost:1234/v1" )

selectEdgesAdjacentToSelectedNodes( network = "network1", base.url = "http://localhost:1234/v1" )

suggestion

selectEdgesAdjacentToSelectedNodes( nodes = unlist(drugnetwork1$V1), network = "network1", base.url = "http://localhost:1234/v1" )

[AlexanderPico]

Nice idea. If we add a new nodes param to that function, however, it would potentially break existing scripts (e.g., that pass in a network as first arg). The process for deprecating an old function and replacing it takes two cycles of Bioconductor releases (a year).

So, an alternative solution might be to introduce a new function: selectEdgesAdjacentToNodes with the params you suggested.

Would this work for you?

[yihangx]

The new function is implemented.

[veroniquevoisin]

yes, sure!

On Tue, Sep 13, 2022 at 3:05 PM Alexander Pico @.***> wrote:

Nice idea. If we add a new nodes param to that function, however, it would potentially break existing scripts (e.g., that pass in a network as first arg). The process for deprecating and old function and replacing it takes two cylcles of Bioconductor releases (a year). So, an alternative solution might be to introduce a new function: selectEdgesAdjacentToNodes with the params you suggested.

Would this work for you?

— Reply to this email directly, view it on GitHub https://github.com/cytoscape/RCy3/issues/190#issuecomment-1245843049, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZYHS4UYNVORLQ7KN5R573V6DGA7ANCNFSM6AAAAAAQLOYQGY . You are receiving this because you authored the thread.Message ID: @.***>