AlexanderPico
commented
1 year ago Indeed. We fixed this in March of 2021 (#115), but then broke it again 7 months later trying to fix #139. We need to try again and thoroughly test all the various edge cases.
@jd690764 As a immediate fix, you can run this code to replace the function with the older version that works for your use case:
.edgeNameToEdgeSUID<-function(edge.names, network=NULL, base.url=.defaultBaseUrl) {
dict <- getTableColumns('edge',c('SUID','name'),'default',network, base.url)
test <- vapply(edge.names, function(x){x %in% dict[,'SUID']}, logical(1))
if(all(test)) #provided SUIDs already!
return(edge.names)
sorted.dict <- NULL
if(length(edge.names) == length(unique(edge.names))){ #unique edge names
sorted.dict <- dict[match(edge.names, dict$name), ]
} else { #multigraph: multiple edges with the same name
message("Finding unique SUIDs for edges with the same name...\n")
match_list <- list()
for(i in seq_along(edge.names)){ #perform match with removal
name_match <- dict[match(edge.names[[i]], dict$name),]
match_list[[i]] <- name_match
dict <- subset(dict, SUID != name_match$SUID)
}
sorted.dict <- do.call(rbind, match_list)
}
edge.SUIDs <- sorted.dict$SUID
return(edge.SUIDs)
}
yihangx
jd690764
I have a similar issue as in #41. I repeated the first example and some of the attributes are not shown in the edge table (see attached screenshot).
RCy3 - 2.18.0 iGraph - 1.4.2 Cytoscape - 3.9.1 R - 4.2.2
Any help would be much appreciated. Thanks, Janos