Closed vttrifonov closed 6 years ago
Thank you for the bug report. Your suggested fix checks out. I've applied it to all similar functions and ran some tests. I'll be pushing this change now. You can get a version via github while waiting for bioconductor to update (up to 48 hours).
The function
.nodeNameToNodeSUID
returns the SUIDs in the order in which they come formgetTableColumns,
instead of preserving the order given in itsnode.names
argument. This creates a problem forsetNodePropetyBypass
because it seems to expect thenode.SUIDs
to be ordered the same as thenode.names
(see the loop in this function): as it is the values and the SUIDs are not guaranteed to be matched.A possible fix to
.nodeNameToNodeSUID
isinstead of
The complication is that there could be multiple SUIDs per name. Of course one has to rework functions that use .
nodeNameToNodeSUID
because it now returns a list.I noticed that some other conversion functions in
RCy3-utils.R
usewhich.
These might have to be corrected to fix any other potential order issues.