Fail silently for admin mail notification

cytoscape / appstore

Cytoscape App Store web application code

16 stars 20 forks source link

Fail silently for admin mail notification #100

Closed mohitdmak closed 2 years ago

mohitdmak commented 2 years ago

Hello @coleslaw481 , would this address #99?

Instead of the whole logger having fail_silently set to true, I think only sending emails to admins upon receiving an error log should fail silently.
So I tried setting it true before the send_mail function gets called inside the default AdminEmailHandler, by extending that class.

coleslaw481 commented 2 years ago

Nice. Thank you. Now I gotta see why the travis build failed

mohitdmak commented 2 years ago

Nice. Thank you. Now I gotta see why the travis build failed

Actually, I saw the Travis logs and tried implementing a fix that you had added in the vagrant setup file, (python-openid probably gets installed as a python2 version). Reinstalling it as python3-openid fixes the issue and the latest test has passed.