search

cytoscape / appstore

Cytoscape App Store web application code
16 stars 20 forks source link

"Install" button in App Store downloads app JAR instead if license prompt is displayed #15

Closed AlexanderPico closed 5 years ago

AlexanderPico commented 8 years ago

Via Tim Hull:

I recently noticed that if you have the App Store website and Cytoscape open, clicking the "Install" button for an app with a license agreement prompt will download the JAR instead of directly installing in Cytoscape after accepting the license agreement. This works fine for apps with no license agreement displayed.

Alex: Or it should only offer "Download" button. IOW, it needs to do what it offers to do.

AdamStuart commented 8 years ago

On this page: http://apps-dev.cytoscape.org/apps/agilentliteraturesearch this license link is 404 http://blueoaksoftware.com/Agilent/ALS/license.html

AlexanderPico commented 8 years ago

That might be by design since it's not the production site. If this is also the case on the live site, then it's a bug.

On Apr 19, 2016, at 1:05 PM, Adam Treister notifications@github.com wrote:

On this page: http://apps-dev.cytoscape.org/apps/agilentliteraturesearch this license link is 404 http://blueoaksoftware.com/Agilent/ALS/license.html

― You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

AdamStuart commented 8 years ago

That might be by design since it's not the production site. If this is also the case on the live site, then it's a bug.

It repo’ed for me in the live site, I filed a ticket.

FWIW, ENViz (shared author) license is functional.
http://bioinfo.cs.technion.ac.il/people/zohar/ENViz/license.html http://bioinfo.cs.technion.ac.il/people/zohar/ENViz/license.html

How do I clear the flag that says I’ve approved licenses so I can retest with the same app?

Adam

On Apr 19, 2016, at 10:22 AM, Alexander Pico notifications@github.com wrote:

That might be by design since it's not the production site. If this is also the case on the live site, then it's a bug.

  • Alex

On Apr 19, 2016, at 1:05 PM, Adam Treister notifications@github.com wrote:

On this page: http://apps-dev.cytoscape.org/apps/agilentliteraturesearch this license link is 404 http://blueoaksoftware.com/Agilent/ALS/license.html

― You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/cytoscape/appstore/issues/15#issuecomment-212025372

AlexanderPico commented 8 years ago

Hmm. Not sure. I thought it prompted the license page every time your download the app.

On Apr 19, 2016, at 2:14 PM, Adam Treister notifications@github.com wrote:

How do I clear the flag that says I�fve approved licenses so I can retest with the same app?