search

cytoscape / appstore

Cytoscape App Store web application code
16 stars 20 forks source link

help/competitions endpoint failing #84

Closed coleslaw481 closed 4 years ago

coleslaw481 commented 4 years ago

Visiting: http://apps.cytoscape.org/help/competitions returns a 505 page.

From viewing the log it looks like the code is incorrectly querying for the App object from the datastore:

appstore/apps/templatetags/app_buttons.py", line 29, in app_button_by_name
    app = App.get(name = app_name)
AttributeError: type object 'App' has no attribute 'get'

The app_button_by_name should be refactored to handle case where app is missing. This also goes for any templates using this method.

coleslaw481 commented 4 years ago

Alex said to remove this

coleslaw481 commented 4 years ago

Removed the help/urls.py reference to help/competitions and fixed apps/templatetags/app_buttons.py to NOT raise an error if no app matches. Th reason for the latter change is the URL rules now consider help/competitions and App and send the request as one to view an App named help