search

cytoscape / appstore

Cytoscape App Store web application code
16 stars 20 forks source link

Port incorrectly added to Server line in app approval and submit emails #87

Closed coleslaw481 closed 4 years ago

coleslaw481 commented 4 years ago

If a user submits or updates an app from https://apps.cytoscape.org (SSL) the Server address displayed in the email sent to the user incorrectly sets the prefix to http:// and adds the port :443 The code should just prefix with https:// and omit the port if the request comes in from port 443

Example:

The following app has been submitted:
    ID: 1
    Server: http://1.0.0.127.in-addr.arpa:443
    Name: Diffusion
    Version: 1.6.1
    Submitter: fakey fake@fake.com
coleslaw481 commented 4 years ago

Fixed in 2.0.2 7974f75..404a0d1 master -> master

The code now leverages the request.is_secure() method to determine whether the URL should start with http:// or https:// and the ports are omitted if SSL and 443 or if non SSL and port 80