Installing new CyNDEx JAR leaves old search bar behind

cytoscape / cy-ndex-2

A Cytoscape client app for the NDEx database

MIT License

0 stars 2 forks source link

Installing new CyNDEx JAR leaves old search bar behind #33

Closed bdemchak closed 7 years ago

bdemchak commented 7 years ago

In installed .17 over .13 and ended up with two search bars.

Also, I expected a message box telling me to restart Cytoscape, but I didn't get one. Should I have?

keiono commented 7 years ago

@bdemchak It is a limitation of app updater code in the core. Do you have the two widgets after restarting Cytoscape?

bdemchak commented 7 years ago

Is this limitation because shutdown code isn't called in the app?? Please elaborate.

I don't have two after restarting ... I have only one.

Should I have seen a "Restart Cytoscape" message?

keiono commented 7 years ago

Restart is not necessary for updates because dependencies are already there, but I can ignore them and ask users to restart.

bdemchak commented 7 years ago

If you can't clean up after the previous app, perhaps you better ask for a restart.

Please explain exactly why you can't clean up (???)

keiono commented 7 years ago

I've checked the shutdown code and it DOES execute the panel removal method. I'll double check this is a core issue or a problem in my code.

keiono commented 7 years ago

@bdemchak Seems restart is required because the new bundle (new version of CyNDEx-2 and all other apps) starts before the shutdown method is called for the old version, that will end up with unpredictable result. Also, removing UI before restart is not possible since App Manager never calls stop method in old bundle activator.