search

cytoscape / cyjShiny

An R/shiny widget for cytoscape.js
Other
92 stars 28 forks source link

drop webpack and all of its complexities #26

Open paul-shannon opened 3 years ago

paul-shannon commented 3 years ago

Hi @oshah97

new branch "abandonWebPack" is working. I suggest:

git clone https://github.com/cytoscape/cyjShiny.git 
cd cyjShiny
git checkout abandonWebPack
make install demo
open http://localhost:9876

The magic glue (pretty opaque to me) is 

   inst/htmlwidgets/cyjShiny.yaml
   inst/htmlwidgets/lib/cytoscape-3.16.2-min.js
   calling  cyj = new cytoscape({container: cyDiv,  elements: data.elements, ...}) from inst/htmlwidgets/cyjShiny.js

Some possibly useful layout options are not included.

oshah97 commented 3 years ago

@paul-shannon Received! Thank you.

oshah97 commented 3 years ago

Hi Paul, It looks like I'm running into some errors with the build. Here's what happens:

Screenshot 2020-10-23 at 16 46 03 Screenshot 2020-10-23 at 16 46 15

Not sure what I'm doing wrong. Also, where in the code does it specify that it will open up in port 9876? Just curious! :) I'm just reviewing some of the R code, and refreshing my memory in the meantime!

paul-shannon commented 3 years ago

Hi Omar,

The “demo” target in the makefile (in the abandonWebPack branch) looks like this:

demo: (cd inst/unitTests; R -f cyjShinyDemo.R )

Do you see that too? Your error message says there is no “demo” target. Let’s make sure you are on the right branch, with a fresh pull, just in case.

port 9876 is specified here:

bash> tail inst/unitTests/cyjShinyDemo.R 

output$value <- renderPrint({ input$action })
output$cyjShiny <- renderCyjShiny(
   cyjShiny(graph, layoutName="cose", styleFile="yeastGalactoseStyle.js")
   )

} # server

----------------------------------------------------------------------------------------------------

runApp(shinyApp(ui = ui, server = server), port=9876)

On Oct 23, 2020, at 7:51 AM, Omar Shah notifications@github.com wrote:

Hi Paul, It looks like I'm running into some errors with the build. Here's what happens:

Not sure what I'm doing wrong. Also, where in the code does it specify that it will open up in port 9876? Just curious! :) I'm just reviewing some of the R code, and refreshing my memory in the meantime!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

paul-shannon commented 3 years ago

successful in branch abandonWebPack-try2 will keep the issue open until we merge this with master