cytoscape / cyjShiny

An R/shiny widget for cytoscape.js
Other
92 stars 28 forks source link

layouts-added #30

Closed Dharna5599 closed 3 years ago

Dharna5599 commented 3 years ago

Hey @paul-shannon , I was going through #29 and got to know about how the package works. I found that few layout features were missing so I added four of them and tested it locally.

Coming to #29, I think I will need some more info inorder to resolve it.

Dharna5599 commented 3 years ago

Hey @paul-shannon, Is it okay if I give you my GSOC proposal for final approval (review) before sending it to the main portal or should I submit it directly?

paul-shannon commented 3 years ago

I’ll be glad to take a look.

On Apr 1, 2021, at 6:03 AM, Dharna Chandrakar @.***> wrote:

Hey @paul-shannon, Is it okay if I give you my GSOC proposal for final approval (review) before sending it to the main portal or should I submit it directly?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Dharna5599 commented 3 years ago

Hey @paul-shannon Is there some way I can get your email address where I can give you the proposal?

paul-shannon commented 3 years ago

@.***

On Apr 1, 2021, at 6:21 AM, Dharna Chandrakar @.***> wrote:

Hey @paul-shannon Is there some way I can get your email address where I can give you the proposal?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Dharna5599 commented 3 years ago

Hey @paul-shannon, Please accept my apologies if this bothers you, but I am unable to understand the email address you have provided, could you please send me back the response?

paul-shannon commented 3 years ago

Ah, github does not allow emails - or so it seems.

Best idea I have on the spur of the moment is for you to find this page, which provides a mail-to link:

https://isbscience.org/bio/paul-shannon/

On Apr 1, 2021, at 6:33 AM, Dharna Chandrakar @.***> wrote:

Hey @paul-shannon, Please accept my apologies if this bothers you, but I am unable to understand the email address you have provided, could you please send me back the response?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Dharna5599 commented 3 years ago

Thank you

paul-shannon commented 3 years ago

There may be some delay in routing mail from the web page I sent you.

So how about this? I just pushed cyjShiny/doc/notes.txt with my email addresses.

On Apr 1, 2021, at 7:24 AM, Dharna Chandrakar @.***> wrote:

Thank you

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Dharna5599 commented 3 years ago

Hey @paul-shannon, This will undoubtedly work, and I have received your email address. Thank you Dharna

Dharna5599 commented 3 years ago

Hey @paul-shannon, I successfully sent you my proposal to one of the given email addresses.  Is it safe to assume, it reached you because there were two email addresses given and I only sent it to one of them?

paul-shannon commented 3 years ago

I have it - thanks. Sorry for the delay. I’ve been busy, and recovering from my second covid vaccine. I’ll try to get you a response later this week.

On Apr 5, 2021, at 9:37 AM, Dharna Chandrakar @.***> wrote:

Hey @paul-shannon, I successfully sent you my proposal to one of the given email addresses. Is it safe to assume, it reached you because there were two email addresses given and I only sent it to one of them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

paul-shannon commented 3 years ago

post-merge comment, if I may: @Dharna5599. As it stands, I do not know how bundle.js was created, or which layouts were added. Here is what would be very helpful - forgive me if you have already added this and I missed it:

Thank you!

Dharna5599 commented 3 years ago

Hi @paul-shannon, As you suggested, I'm working on documentation to make a clear note of how I added some layouts that were previously missing in cyjShiny, and after the consultation, I'll send it here via github.