cytoscape / cyjShiny

An R/shiny widget for cytoscape.js
Other
92 stars 28 forks source link

Use of `ready()` in `renderValue()` #6

Open maxkfranz opened 6 years ago

maxkfranz commented 6 years ago

Generally, ready() should be used only for things that rely on async things from init happening first before your ready() code, but that doesn't seem to be the case here:

https://github.com/cytoscape/cyjShiny/blob/9a69ccb2a399465a136811a99f4f8d62c1b40379/inst/browserCode/src/cyjShiny.js#L37-L47

paul-shannon commented 6 years ago

@maxkfranz - thanks. I hoped to get suggestions of exactly this sort.