search

cytoscape / cytoscape.js-cxtmenu

Context menu for Cytoscape.js
MIT License
165 stars 83 forks source link

Add: hover function is fired to the active element #137

Closed cicarulez closed 1 year ago

cicarulez commented 1 year ago

Please update TypeDefinition

stale[bot] commented 1 year ago

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

maxkfranz commented 1 year ago

It looks like it's working correctly.

@cicarulez, would you add your new option in the documentation in the readme? I noticed that it doesn't activate the hover function for disabled menu items. That may be the most sensible option, but that edge case should be documented in the readme so that users of the extension aren't surprised by how it works.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

maxkfranz commented 1 year ago

@cicarulez, are you still interested in adding the readme documentation to this PR for your feature?