cytoscape / cytoscape.js-dagre

The Dagre layout for DAGs and trees for Cytoscape.js
MIT License
249 stars 83 forks source link

undefined - cytoscape.util.requestAnimationFrame with v2.5.0 cytoscape and navigator #2

Closed melborp closed 8 years ago

melborp commented 8 years ago

Using cytoscape 2.5 and darge layout. It throws null / undefined on the cytoscape.util.requestAnimationFrame. in this case the util seems to be undefined. Something changed / broke in 2.5? I've tried to find release notes for 2.5 with breaking changes, didnt find it.

From Chrome: Uncaught TypeError: Cannot read property 'requestAnimationFrame' of undefined Navigator._updateThumbnailImage @ cytoscape.js-navigator.js:548 Navigator._setupThumbnail @ cytoscape.js-navigator.js:138 Navigator._initThumbnail @ cytoscape.js-navigator.js:116 (anonymous function) @ cytoscape.js-navigator.js:36 triggerImpl @ cytoscape.js:8341(anonymous function) @ cytoscape.js:6615 triggerImpl @ cytoscape.js:8341(anonymous function) @ cytoscape.js:5795 triggerImpl @ cytoscape.js:8341triggerImpl @ cytoscape.js:8365 elesfn.layoutPositions @ cytoscape.js:4693 DagreLayout.run @ cytoscape-dagre.js:162 corefn.layout @ cytoscape.js:6910 callback @ cytoscape.js:5804

melborp commented 8 years ago

Moving


    var raf = !window ? null : (window.requestAnimationFrame || window.mozRequestAnimationFrame || window.webkitRequestAnimationFrame || window.msRequestAnimationFrame);

    raf = raf || function (fn) { if (fn) { setTimeout(fn, 1000 / 60); } };

    var requestAnimationFrame = function(fn) {
        raf(fn);
    }

from cytoscape 2.5 to the navigator code and then calling it doesnt seem to be enough to make navigator work.

        //cytoscape.util.requestAnimationFrame( render );
        requestAnimationFrame(render);
    }

      //cytoscape.util.requestAnimationFrame( render );
    requestAnimationFrame(render);
melborp commented 8 years ago

wrong location