search

cytoscape / cytoscape.js-dagre

The Dagre layout for DAGs and trees for Cytoscape.js
MIT License
246 stars 82 forks source link

Layout bugged due to compound node order #61

Closed riverchen99 closed 3 years ago

riverchen99 commented 3 years ago

The layout produced by dagre on graphs with compound nodes breaks when the parent node follows children nodes in the list of elements.

Please take a look at some additional details here: https://github.com/plotly/dash-cytoscape/issues/112

@xhlulu produced a gist reproducing the issue with pure javascript.

Thanks!

maxkfranz commented 3 years ago

This looks like an issue within Dagre itself. So the best way to resolve this would be to file an issue with Dagre: https://github.com/dagrejs/dagre/issues

If you can identify the root issue in Dagre, they may be open to a pull request. Alternatively, if you can identify a workaround within this wrapper extension, I could help to review that PR so that at least Cytoscape users aren't affected by this issue. It would be preferable to address the issue within Dagre so that even non-Cytoscape users benefit from the fix, though a workaround for Cytoscape users may be a bit faster.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale, because it has not had activity within the past 30 days. It will be closed if no further activity occurs within the next 30 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

gabrywu commented 2 years ago

So, what's the conclusion?

marc-vdm commented 2 years ago

It seems dagre is deprecated, will this issue be taken up here? Unfortunately, I don't have the JS expertise to help out but I'd benefit from having this in Dash Cytoscape!

maxkfranz commented 2 years ago

Have you reached out to Dash/Plotly support? https://dash.plotly.com/support