search

cytoscape / cytoscape.js-navigator

Bird's eye view pan and zoom control for Cytoscape.js.
MIT License
67 stars 42 forks source link

remove jquery dependency #27

Closed tongbin closed 6 years ago

tongbin commented 8 years ago

Hi @maxkfranz again, I'll also need this plugin without jQuery, which will be great for usage in react/redux frameworks, please review if this's worth for merging back into master project, or there is any problem.

Thanks a lot, you're always quite helpful. ^_^

maxkfranz commented 8 years ago

Since this uses the same approach as you did in edgehandles, we should probably address this first: https://github.com/cytoscape/cytoscape.js-edgehandles/issues/42

tongbin commented 8 years ago

@maxkfranz please review this when you've time, thanks very much! It's the same thing what we did in edge handles.

maxkfranz commented 8 years ago

@tongbin Thanks. I won't be able to review this until the 28 October. Sorry for the delay, but I'll look at it as soon as I'm able.

tongbin commented 8 years ago

Thanks for your time, no hurry.

maxkfranz commented 7 years ago

@tongbin Sorry for the delay. I've been really busy. Can you try with the latest jQuery replacement in edgehandles?

There's at least this bug that has been fixed in the replacement: https://github.com/cytoscape/cytoscape.js-edgehandles/issues/51