cytoscape / cytoscape.js

Graph theory (network) library for visualisation and analysis
https://js.cytoscape.org
MIT License
9.98k stars 1.63k forks source link

📚🐛 Some demos in the docs are broken due to 404 error fetching `cytoscape.min.js` #3259

Closed s-weigand closed 1 month ago

s-weigand commented 1 month ago

Currently, some demos (e.g edge-types) are broken due to the missing cytoscape.min.js (https://js.cytoscape.org/js/cytoscape.min.js). image

The reason for this is that the file got copied into a build subfolder of the js folder on the gh-pages branch image

The dependabot update in #3247 bumped cpy-cli from 3.1.1 to 5.0.0 where 4.0.0 introduced the breaking change:

Remove the --parents flag. The copy is now recursive by default. To get flat output, use the --flat flag.

Note that some demos (e.g. edgehandles) still work because they use https://unpkg.com/cytoscape@3.30.0/dist/cytoscape.min.js instead of https://js.cytoscape.org/js/cytoscape.min.js.

Current (buggy) behaviour

Some demos are broken because https://js.cytoscape.org/js/cytoscape.min.js gives a 404 HTTP error.

Desired behaviour

All demos work.

Minimum steps to reproduce

Go to the edge-types demo in current docs and see that it is broken (open browser dev tools to see why).

Alternatively, locally build the doc for the current version of the default branch locally

npm ci && npm run build:min && npm run docs

Serve the documentation folder locally and visit the edge-types demo

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

s-weigand commented 1 month ago

Duplicate of #3257 but with explanations 😅