cytoscape / enrichment-map-webapp

MIT License
6 stars 0 forks source link

Revised bubble/cluster behaviour #274

Closed maxkfranz closed 6 months ago

maxkfranz commented 8 months ago

General information

Update the bubbles, with most of the revised behaviour. Changes on dev.

Associated issues:

Checklist

Author:

Reviewers:

Notes

The labels are easier to read:

Screenshot 2024-03-11 at 14 14 46

Bubbles are easy to drag:

https://github.com/cytoscape/enrichment-map-webapp/assets/989043/318ab297-f77f-4587-a80e-33e935a7a5f4

Selecting a bubble shows you the genes in it:

https://github.com/cytoscape/enrichment-map-webapp/assets/989043/93756779-1a52-4e3c-a20d-0d9214356101

Expanding fits to screen when needed:

https://github.com/cytoscape/enrichment-map-webapp/assets/989043/48865d0e-c489-42fa-be4b-c47149db3f5a

maxkfranz commented 8 months ago

Note: The expand/collapse icon isn't shown when a bubble is expanded. The icon got in the way of the nodes. Tapping the bubble to collapse it is also disabled. It's easy to tap the background to collapse, and this way the icon doesn't get in the way of the nodes when the child labels are visible.

maxkfranz commented 8 months ago

Bonus update: The bubbles follow the nodes smoothly.

Before:

https://github.com/cytoscape/enrichment-map-webapp/assets/989043/531a3fea-f929-415a-9f23-e61e2c92bd0d

After:

https://github.com/cytoscape/enrichment-map-webapp/assets/989043/6ff4364d-f318-4231-bcc2-3e2f0bf60fbf

maxkfranz commented 8 months ago

Edges don't get in the way of bubble labels, expanding bubbles, or dragging bubbles:

https://github.com/cytoscape/enrichment-map-webapp/assets/989043/ed824959-3e99-4f60-8a74-2d29e47948f9

maxkfranz commented 8 months ago

Black labels, since there isn't space to see the nodes. We need to see the nodes if we use a mapper for the p-value.

Screenshot 2024-03-11 at 18 32 27

The labels are always legible, even when there's node or edge overlap:

Screenshot 2024-03-11 at 18 34 50 Screenshot 2024-03-11 at 18 35 00
mikekucera commented 8 months ago

Hi Max, I can give you my opinion on the changes, but you're the one who talked to the users so my opinion my not be valid... Feel free to disregard.

Before:

Screenshot 2024-03-12 at 11 05 23 AM

After:

Screenshot 2024-03-12 at 11 03 43 AM Screenshot 2024-03-12 at 10 55 29 AM

Here's an example where the pathway name is abbreviated in the table but not in the network :)

Screenshot 2024-03-12 at 11 16 35 AM