Closed maxkfranz closed 6 months ago
Note: The expand/collapse icon isn't shown when a bubble is expanded. The icon got in the way of the nodes. Tapping the bubble to collapse it is also disabled. It's easy to tap the background to collapse, and this way the icon doesn't get in the way of the nodes when the child labels are visible.
Bonus update: The bubbles follow the nodes smoothly.
Before:
After:
Edges don't get in the way of bubble labels, expanding bubbles, or dragging bubbles:
Black labels, since there isn't space to see the nodes. We need to see the nodes if we use a mapper for the p-value.
The labels are always legible, even when there's node or edge overlap:
Hi Max, I can give you my opinion on the changes, but you're the one who talked to the users so my opinion my not be valid... Feel free to disregard.
Before:
After:
The selection color makes labels hard to read when selected. Why are we using dark grey instead of yellow?
The labels for many pathways are very long. Maybe they should be shortened with ellipsis?
Here's an example where the pathway name is abbreviated in the table but not in the network :)
General information
Update the bubbles, with most of the revised behaviour. Changes on dev.
Associated issues:
264
Checklist
Author:
Reviewers:
Notes
The labels are easier to read:
Bubbles are easy to drag:
https://github.com/cytoscape/enrichment-map-webapp/assets/989043/318ab297-f77f-4587-a80e-33e935a7a5f4
Selecting a bubble shows you the genes in it:
https://github.com/cytoscape/enrichment-map-webapp/assets/989043/93756779-1a52-4e3c-a20d-0d9214356101
Expanding fits to screen when needed:
https://github.com/cytoscape/enrichment-map-webapp/assets/989043/48865d0e-c489-42fa-be4b-c47149db3f5a