cytoscape / enrichment-map-webapp

MIT License
6 stars 0 forks source link

Feature/report #301

Closed mikekucera closed 4 months ago

mikekucera commented 4 months ago

General information

Associated issues: #299

Checklist

Author:

Reviewers:

Notes

Screenshot 2024-07-04 at 10 04 56 AM
maxkfranz commented 4 months ago

@mikekucera @chrtannus

I'll put in a review tomorrow

chrtannus commented 4 months ago

It looks good to me! Only one minor issue: when sorting by name, it should be case insensitive. In the example below, brca_hd_tep_ranks should be the first item:

ASC-sort-name

mikekucera commented 4 months ago

Good catch. Thanks.

mikekucera commented 4 months ago

I added a fix for the sorting issue to this branch. It also fixes the pathway table (#302).

maxkfranz commented 4 months ago

LGTM