search

cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
269 stars 62 forks source link

adding two examples - learn cyto from scrach 1 and 2 #205

Closed joseberlines closed 3 years ago

joseberlines commented 3 years ago

Hi @marimeireles Hi @ianhi

This pull request add two examples to the repository. Both corresponding to the two medium articles published.

publicly available: https://joseberlines.medium.com/learning-and-visualising-graphs-with-ipycytoscape-1ca150f24933

still unlisted https://joseberlines.medium.com/part-2-learning-graphs-with-ipycytoscape-the-train-rail-net-grows-up-db2daa2f453d

bear in mind that this is my second pull request ever....

joseberlines commented 3 years ago

I accepted all your changes. First time I do this. I hope its not a mess on your side.

ianhi commented 3 years ago

I accepted all your changes. First time I do this. I hope its not a mess on your side.

You're doing just fine :)

ianhi commented 3 years ago

Heads up that at some point in the all the reviews implemented on github I think that notebook1 got corrupted. At the very least I seem to be unable to open it in jupyterlab

joseberlines commented 3 years ago

Lets see if thats the case for mariana as well since she was the one proposing the changes. Perhaps the best its me creating a repo containing just those notebooks and the ones to come.

marimeireles commented 3 years ago

Hi @joseberlines thanks for the fixes :) If you want to create your own repo is fine too, we can link it here on the docs and readme if you want. Sorry it's so much trouble to upload your changes to this repo! But as Ian said you're doing fine :) Btw, I saw Ian pointed you to grammarly, it'd be good to give it a pass on the notebooks too. If you're too busy to do it in the second notebook we can merge only one of the notebooks and leave the second one for later. Your choice! I'm gonna look it up what's going on with the rendering of the repo. Thanks again.

Hey @ianhi thanks for jumping in and testing. Could be because of the automatic review maybe...?

joseberlines commented 3 years ago

Hei. Thats a good idea. If you can merge just the first notebook. Fine to me. And I give another look (grammar) to the second. Just for info the second notebook contains actually a function that I would like to PR in the core code of ipycyto (create geaphs from pandas). But i would like to have your opinion first. Even if the notebook is not perfect if you just run it you realise what I am up to. I dont have any preference as how to go only whats easier for all of us. I was approached by a couple of people to include my first medium article in their course. Thats why this time i did not publish yet before your input. Conclusion if you can accept first one and i will make a new request for the second one.

marimeireles commented 3 years ago

If you can merge just the first notebook Will do.

But i would like to have your opinion first. Even if the notebook is not perfect if you just run it you realise what I am up to. I dont have any preference as how to go only whats easier for all of us

Yeah, sure! I will and will open a PR on it.

I was approached by a couple of people to include my first medium article in their course. Thats why this time i did not publish yet before your input.

No problem at all, you're totally free to publish any time :) And that's reeeally cool, thanks for sharing.

joseberlines commented 3 years ago

OK. I am rewriting cyto_from_scratch_2 and I divided it. Now there is also cyto_from_scratch_3_with_pandas

marimeireles commented 3 years ago

Finally merged, thank you so much for all the work here and the patience @joseberlines :) I added your series of blog in the readme, feel free to change it/update it when you release the 2nd and 3rd.

joseberlines commented 3 years ago

Ok. Thanks. It means a lot to me. First ever contribution to a library.

The next PR will be one by one. The lessons 2, 3 are ready. 4 on tbe making.