search

cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
265 stars 62 forks source link

Attempt to speed up CI #207

Closed ianhi closed 3 years ago

ianhi commented 3 years ago

Using pip cache and more of the premade setup actions.

ianhi commented 3 years ago

So because the Cache hadn't been instantiated yet that run of CI didn't make use of the pip cache dir but still ended up running ~2 minutes faster.

However, there is a downside here in that the install steps are now less similar to what users will be doing and we won't always pick up the newests versions of dependencies. @marimeireles what do you think? is the speedup worthwhile?

marimeireles commented 3 years ago

Hey @ianhi thanks for the PR :) Why are we not gonna get the newest versions of the dependencies now? Will the pip-cache command prevent it somehow?

now less similar to what users will be doing

You mean because we're not using conda-forge anymore? I don't think that's an issue tbh.

In my personal perspective if we can save 2mins of processing somewhere we should =)

ianhi commented 3 years ago

Why are we not gonna get the newest versions of the dependencies now? Will the pip-cache command prevent it somehow?

I was worried about how often the cache is updated. This action only ever explicitly updates it if the hash of setup.py has changed. But from https://github.com/actions/cache#cache-limits

Caches that are not accessed within the last week will also be evicted

So there will be fairly regular turnover on the versions pulled down by pip.