search

cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
265 stars 62 forks source link

combine add_node with add_nodes and add_egde with add_edges #214

Closed SvenSchiffner closed 3 years ago

SvenSchiffner commented 3 years ago

Mentioned in #195

ianhi commented 3 years ago

This doesn't need to happen here but at some point checks should be added to add_edges and add_nodes that the node/edge being added is actually the correct object and if not we should fail with a clear error message.

marimeireles commented 3 years ago

Awesome change @sven5s :) Thanks for the PR!

SvenSchiffner commented 3 years ago

This doesn't need to happen here but at some point checks should be added to add_edges and add_nodes that the node/edge being added is actually the correct object and if not we should fail with a clear error message.

This is a really good point. We should open an issue to keep track of this.

ianhi commented 3 years ago

@sven5s this will get picked up into the release adding jlab3 support which should be soonish