search

cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
269 stars 62 forks source link

Restore lazy loading #221

Closed ianhi closed 3 years ago

ianhi commented 3 years ago

Problem

We used to lazy load our js, but that got lost in the transition to jlab 3 due to issues when building the wheels. see https://github.com/QuantStack/ipycytoscape/pull/171#discussion_r551487495

Proposed Solution

Bring back the lazy loading.

marimeireles commented 3 years ago

Hey Ian and @bollwyvl, thanks :) Does this https://github.com/QuantStack/ipycytoscape/commit/71a61769fc843a7098b621287e1b84d5a8359afc close this issue?

ianhi commented 3 years ago

Does this 71a6176 close this issue?

Yup! Good catch