cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
269 stars 62 forks source link

Remove @0.2.3 from jupyter-cytoscape in postBuild #234

Closed sandertyu closed 3 years ago

sandertyu commented 3 years ago

Problem

When trying to debug ipycytoscape in a JupyterHub deployment that I help manage, I was testing a repo2docker image that we build with ipycytoscape=1.2.0 and it was not working because our jupyterlab=2.2. I was comparing the extensions used in the postBuild of our environment against the one in this repository and noticed that the jupyter-cytoscape extension is pinned to jupyter-cytoscape@0.2.3. This is well out of date, and when actually built, jupyter labextension list shows jupyter-cytoscape v1.2.0;

jupyter labextension list

Proposed Solution

The pin for @0.2.3 should probably simply be removed from postBuild. I've made a PR to do this. Ipycytoscape has code to automatically match the ipycytoscape version to the labextension jupyter-cytoscape version anyways.

Additional context

Furthermore, jupyter-cytoscape>1.0.4 does not seem to be hosted in this (somewhat?) official npm repository. I suggest that newer versions are either uploaded to here or it is made clear that this is an archived npm repository for jupyter-cytoscape that works only on jupyterlab2 and ipycytoscape<=1.0.4.

marimeireles commented 3 years ago

Thank you for your issue and your fix @sandertyu. So yeah, you're right about the npm repo, @ianhi and I forgot to upload the package there somehow! I'll fix it right away and close this issue once it's fixed. Thanks for the catch!

marimeireles commented 3 years ago

Hey @sandertyu thanks again, fixed here.