search

cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
269 stars 62 forks source link

added support for Neo4j subgraphs, closes #226 #237

Closed pwrose closed 3 years ago

pwrose commented 3 years ago

added add_graph_from_neo4j method to support rendering of Neo4j subgraphs. Added an example notebook.

marimeireles commented 3 years ago

@marimeireles the tests are also trying to run Neo4j_Example.ipynb on binder, however, this will not work since binder blocks required ports. Can you exclude Neo4j_Example.ipynb from running on binder?

I'm not sure if I follow you here. The tests are run on an ubuntu, here's the code for it. We will definitely need to make some changes to the tests to cover your tests...

pwrose commented 3 years ago

The error message indicates that the Neo4j query returned no results. Perhaps run the notebook again once the code is checked in. It works fine when I run it locally.

ianhi commented 3 years ago

Hi @pwrose glad to see work on this progressing. Is it ready for review?

Also, you should be able to fix the lint issues by running black . from the terminal while in the ipycytoscape directory.

pwrose commented 3 years ago

I'm closing this pull request since I made some changes and improvements.

pwrose commented 3 years ago

Thanks for the tip about black. I’ll try to get this ready tomorrow and then you can review the code.

From: Ian Hunt-Isaak notifications@github.com Reply-To: QuantStack/ipycytoscape reply@reply.github.com Date: Sunday, February 28, 2021 at 9:38 PM To: QuantStack/ipycytoscape ipycytoscape@noreply.github.com Cc: Peter Rose pwrose@ucsd.edu, Mention mention@noreply.github.com Subject: Re: [QuantStack/ipycytoscape] added support for Neo4j subgraphs, closes #226 (#237)

Hi @pwrosehttps://urldefense.com/v3/__https:/github.com/pwrose__;!!Mih3wA!SNYP6INChd6zmgvjuYOXhmHzYdV83ZE91t-1AZ6fy99WN5coK4hu2Q6p5mzWinQ$ glad to see work on this progressing. Is it ready for review?

Also, you should be able to fix the lint issues by running black . from the terminal while in the ipycytoscape directory.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/QuantStack/ipycytoscape/pull/237*issuecomment-787655906__;Iw!!Mih3wA!SNYP6INChd6zmgvjuYOXhmHzYdV83ZE91t-1AZ6fy99WN5coK4hu2Q6pDkVVLH4$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AA53AECCK26M342SKPMFUTTTBMR3RANCNFSM4XMPZSYQ__;!!Mih3wA!SNYP6INChd6zmgvjuYOXhmHzYdV83ZE91t-1AZ6fy99WN5coK4hu2Q6pLqsCBTU$.

pwrose commented 3 years ago

@ianhi I've added a new pull request #245 that is ready for review. The lint test passes, but the other 3 tests fail. I'm not sure how to interpret the error messages and what needs to be fixed.