Closed vaniisgh closed 2 years ago
Hi @vaniisgh thanks for taking this on! This looks like a good start but there are a few things to clean up.
TODO:
__init__
with parameters sectionfrom_json
method (I'll add an inline review) (edit I think you did this correctly and I was just reading the code too fast - my bad!)graph_file
to something more general.
black .
Also looking at the test failures there are unfortunately several due to neo4j which aren't your fault. This makes it trickier to see if your are causing issues but you can look more closely by clicking on the details
next to the failing test.
hey thank you so much for the feedback! I tried to take the things you mentioned into account and made a few changes. Though, I still think I might need to revise my work a bit. Also, I apologize forgot to rebase my work on the current master I hope I did it correctly now.
I think it should be better now :)
Thanks for the ping! This slipped through the cracks for me - can look later
@ianhi should i close this ?
Thank you @vaniisgh !! This is a great addition and we can always iterate more as needed.
@ianhi should i close this ?
Definitely not that - I'm really sorry about the long periods of non-responsiveness that's totally on me. I really appreciate you coming and putting the effort to make a positive change. I can't promise to be perfect, but I can promise that I will at least try to be more honest myself about what I can claim to do. Also don't be scared to ping more and more often (though ideally course you shouldn't have to :/ )
This should be live in version 1.3.0
soon!
Hey, This issue ( #94 ) looked interesting and beginner-friendly, I just wanted to know if this was a good start.