Add new API to change style

cytoscape / ipycytoscape

A Cytoscape Jupyter widget

https://ipycytoscape.readthedocs.io/en/master/

BSD 3-Clause "New" or "Revised" License

264 stars 62 forks source link

Add new API to change style #272

Open marimeireles opened 3 years ago

marimeireles commented 3 years ago

This PR fixes the buggy behavior seen here

We still need some tests! Forgot to add those. If anyone is feeling like it, please go ahead!

Otherwise I'll add them eventually :)

github-actions[bot] commented 3 years ago

:point_left: Launch a binder notebook on branch marimeireles/ipycytoscape/style

marimeireles commented 3 years ago

This PR does affect the behavior of ipycytoscape because before people were counting on the complete erasure of the style to add their new styles. So now... We either have to fix the examples by adding clear_style every time someone adds a new style to the cytoscape obj or better yet we conform to the new API added here. I'm thinking about also writing something on the README to let users know of this API change. It ended up having more impacts than I first anticipated. :/