search

cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
264 stars 62 forks source link

What to do with the pre-commit tool #299

Closed marimeireles closed 2 years ago

marimeireles commented 2 years ago

We're getting this kind of error of our pre-commit thingy: https://results.pre-commit.ci/run/github/238460517/1642317160.jW4EH-NuS1eqYcHn0ZI9iA

I don't really understand where it's coming from. The only pre-commit thing we have is:

  "husky": {
    "hooks": {
      "pre-commit": "lint-staged"
    }
  },

on our package.json. @ianhi any idea? Seems like we need a .pre-commit-config.yaml file to fix it, does this make sense? Should we migrate to another tool?

ianhi commented 2 years ago

indeed we do need that file - sorry i never added it after the tool was enabled. This is nice because it can combine fixes for python and ts into one tool. I'd suggest we follow the one ipympl uses - I can make a pr