Closed ianhi closed 2 years ago
oh boy:
The failing test is one that was actually never being run before and that I discovered wasn't being due to the flake8 checks. Confused by the python version dependency though
This is such a weird error 😅 Can't reproduce it locally What's up with these CIs
I reran the test and now another python is unhappy for another weird reason.
I did a bit of experimenting on https://github.com/jenshnielsen/ipycytoscape/pull/4 and it looks like the test failure can indeed be reproduced by only renameing the second test_add_edges to avoid collisions. It may be worthwile extracting that from this pr marking it as xfail and then merge the rest of this and fix it in a subsequent pr ?
https://github.com/cytoscape/ipycytoscape/pull/308 should resolve the test issue while still running all the tests
Thanks @jenshnielsen ! just rebased
Should fix: https://github.com/cytoscape/ipycytoscape/issues/299
@marimeireles do you think the instructions on usage are through enough? I can add more - could also imagine adding instructions for what to do once the bot pushes to your PR.
I expect the checks to fail as this repo has some flake8 issues (which we could ignore by removing the flake8 check)