cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
261 stars 62 forks source link

Upgrade Webpack to version 5 #312

Closed jenshnielsen closed 2 years ago

jenshnielsen commented 2 years ago

To do this it required setting production path as in ipympl and change the webpack cli from -p to --mode=production which should be indentical.

I have manually tested that a local build of the notebook extension still works as expected.

Note that since this does an npm update the changes to package-lock.json are significant. It could be worthwile updating the package lock file independently before this pr.

closes #224

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on branch jenshnielsen/ipycytoscape/webpack5

jenshnielsen commented 2 years ago

Thanks, just trying to land small things that I find I as I familarilze my self with the codebase and how the ts/js/python stuff is integrated. Was experimenting to see if updating javascript packages would change any thing