cytoscape / ipycytoscape

A Cytoscape Jupyter widget
https://ipycytoscape.readthedocs.io/en/master/
BSD 3-Clause "New" or "Revised" License
261 stars 62 forks source link

Upgrade most javascript dependencies to latest versions #315

Closed jenshnielsen closed 2 years ago

jenshnielsen commented 2 years ago

I have manually tested that this works correctly for me in both Jupyter lab 3 and notebook.

With this change all javascript dependencies are up to date except the following which requires an apation of the tooltip calls since tippy/popper has changed their api.


❯ npm outdated
Package           Current  Wanted  Latest  Location                       Depended by
cytoscape-popper    1.0.7   1.0.7   2.0.0  node_modules/cytoscape-popper  ipycytoscape
tippy.js            5.2.1   5.2.1   6.3.7  node_modules/tippy.js          ipycytoscape
github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on branch _jenshnielsen/ipycytoscape/upgrade_javascriptdeps

marimeireles commented 2 years ago

Hi @jenshnielsen, thanks for the PR!

So, actually, one thing worries me about the PR, setting everything for the latest version could cause some version conflicts in user's machines that depend on older software. I asked my colleagues and the preferred way to go about versioning is by adding a lower boundary of suport and a high one. For the low, I'd say we can use whatever it was the lowest before and for the highest, we can use the new values you added on this PR. What do you think?

example:

node>=13.2.0,<=17.0.0

marimeireles commented 2 years ago

Hey @jenshnielsen thanks for opening this, but I updated it with npm update seems like the recommend way of doing by npm and seems to work fine.