search

cytoscape / py2cytoscape

Python utilities for Cytoscape and Cytoscape.js
https://py2cytoscape.readthedocs.io
MIT License
178 stars 45 forks source link

Update loader.js #43

Closed cs48a closed 6 years ago

cs48a commented 7 years ago

It seems like cystoscape.min.js has been relocated and is no longer accessible at: http://cytoscape.github.io/cytoscape.js/api/cytoscape.js-latest/cytoscape.min, however even from a valid address (e.g. https://raw.githubusercontent.com/cytoscape/cytoscape.js/master/dist/cytoscape.min.js) it appears to be uncompatible (the reason is beyond my understanding) from version 3.0.0 cytoscape.min.js does not work. Using a legacy version available at cloudflare worked for me.

athityakumar commented 6 years ago

Ping @idekerlab - the library doesn't work without this change. Please merge and release a new version as soon as possible. 😄

JamesPino commented 6 years ago

This is needed to use the package. Any ideas when it will be approved?

jorgeboucas commented 6 years ago

Given the latest commit https://github.com/cytoscape/cytoscape.js/commit/c8aa6c4b2502aa9c5d6c2def122d1b1df8fc3c49 from @maxkfranz I've committed 4704cc2

do feedback - thanks!

maxkfranz commented 6 years ago

@jorgeboucas Thanks for the update, but a good, robust, longterm solution would be to use npm+webpack or npm+browserify to build your loader.js file and manage its dependencies properly. py2cytoscape should really only be using exact versions of the cytoscape package that have been tested and vetted -- on a per-release basis of py2cytoscape.

npm init && npm i -D browserify && npm i -S cytoscape would be the fastest/easiest way to set this up if you're unfamiliar with js tooling. Then use an npm script like "build": "browserify loader.src.js -o loader.js".

Until this change is made, py2cytoscape is at risk of breaking just as it did before -- at any time. An added benefit of this change would be that this software could be used offline.

A quick, temporary workaround would be to use unpkg or cdnjs, e.g. https://unpkg.com/cytoscape@3.2.8/dist/cytoscape.min.js. Github is not a cdn, and pointing to a branch rather than a version number of a release is risky.