cyu / rack-cors

Rack Middleware for handling Cross-Origin Resource Sharing (CORS), which makes cross-origin AJAX possible.
MIT License
3.27k stars 262 forks source link

removed 'with' from 'with with' #141

Closed dapperAuteur closed 7 years ago

dapperAuteur commented 7 years ago

small grammar change

olleolleolle commented 7 years ago

@cyu I believe this PR fixes a detail. Review?

cyu commented 7 years ago

@olleolleolle no, taking away the with changes the meaning I think. Having said that, there might be better ways to say it. What do you think about this?

We use insert_before to make sure Rack::Cors runs at the beginning of the stack to make sure it isn't interfered with withby other middleware

cyu commented 7 years ago

Fixed with 4557f7d