search

cyucelen / marker

🖍️ Marker is the easiest way to match and mark strings for colorful terminal outputs!
MIT License
48 stars 13 forks source link

Adding matchPalindrome matcher feature #23

Closed Srivats1991 closed 4 years ago

Srivats1991 commented 5 years ago

I thought I will add one more matcher scenario. Please review my code and let me know if there's anything better I can do. Thanks!

codecov-io commented 5 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         121    138   +17     
=====================================
+ Hits          121    138   +17
Impacted Files Coverage Δ
matcher.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a90a7b5...575ca6d. Read the comment docs.

cyucelen commented 5 years ago

@jnatalzia can you review? since you have more idea about context.

jnatalzia commented 5 years ago

@Srivats1991 code looks good but I still think we should be limiting the characters that match palindrome. See my comment here: https://github.com/cyucelen/marker/pull/23#discussion_r335496879