cyucelen / marker

🖍️ Marker is the easiest way to match and mark strings for colorful terminal outputs!
MIT License
47 stars 13 forks source link

Generate images for readme #25

Closed Darkclainer closed 4 years ago

Darkclainer commented 4 years ago

It doesn't work as intended, but maybe somebody know how to fix this.

I made script that generates svg files and crop them. And it's works when I open image in browser! But when I try to include image in README.md it looks awful. I can not control it size, and worse - crop doesn't work. (look https://github.com/Darkclainer/marker/blob/generate_images_for_readme/assets/svg/showoff.svg)

I tried to convert this svg files to png, but not inkspace nor cairosvg don't read this files correctly.

Your ideas?

Issue #18

codecov-io commented 4 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         106    106           
=====================================
  Hits          106    106

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d80815...76018eb. Read the comment docs.

jnatalzia commented 4 years ago

Looks like based on the description in https://github.com/cyucelen/marker/pull/26 that this PR is no longer needed. Can we close this?

Darkclainer commented 4 years ago

I more like approach in this PR, but if nobody know how to fix problems with svg - I don't mind.

cyucelen commented 4 years ago

Can you try svgexport

svgexport email.svg output.png 0:0:640:18

Does the job but image quality looks bad, maybe we can do something about it.

Darkclainer commented 4 years ago

I have seen this library, but it is in js, so it will be another big requirement to start this script.

cyucelen commented 4 years ago

Yes, but it is the only one that reads our svg correctly :confused: Maybe we should go with html->png of your PR.

Darkclainer commented 4 years ago

OK.