Updated code to pull request

bhatnagarm commented 5 years ago

Adding further to versioning.

keidrych commented 5 years ago

Looks good, a few points which can either be updated here or refactored in future:

path naming: 'core/operation/GET/v0.js'. I'd suggest this be simpler and follow the lowercase standard: 'core/{endpoint name}/get/v0.js'
_init function: logically the establishment of the route version could be stripped out of the 'get/index.js' file entirely and pushed upwards into the core 'index.js' as a common function to reduce boilerplate code
microgen: is possibly not the most suitable library choice anymore as its most suited to individual files and this change means all new endpoints will have a minimum of 3 files that need to be added in a specific directory structure. Versioning within those endpoints would also need to check for existence of two files currently.

Happy to accept the pull request as is and raise separate issues for the above 3 items

bhatnagarm commented 5 years ago

Hi Keidrych, I have updated the first part. I will update the rest in later pull request.

Thanks and regards, Mitul Bhatnagar

cyvive / agnostic