search

cyyynthia / pronoundb.org

A browser extension that lets people know how to refer to each other on various places of the Internet. Available on Chrome, Firefox, and Edge.
https://pronoundb.org
BSD 3-Clause "New" or "Revised" License
271 stars 22 forks source link

feat: add norwegian pronouns (incomplete) #109

Open adalinesimonian opened 7 months ago

adalinesimonian commented 7 months ago

Adds support for Norwegian pronouns (both official written languages — Bokmål and Nynorsk).

I went to begin adding the necessary support on the website to support multiple locales, however I am encountering this error both in the browser and CLI when building the website:

Cannot read properties of undefined (reading 'startsWith')
  Stack trace:
    at connectionStringHasValidScheme (C:\Users\Adaline\GitHub\cyyynthia\pronoundb.org\node_modules\.pnpm\mongodb-connection-string-url@3.0.0\node_modules\mongodb-connection-string-url\lib\index.js:9:30)
    at parseOptions (C:\Users\Adaline\GitHub\cyyynthia\pronoundb.org\node_modules\.pnpm\mongodb@6.3.0\node_modules\mongodb\lib\connection_string.js:186:17)
    at file:///C:/Users/Adaline/GitHub/cyyynthia/pronoundb.org/packages/website/dist/server/chunks/pages/404_qEx_xJ8G.mjs:8:16
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async generatePages (file:///C:/Users/Adaline/GitHub/cyyynthia/pronoundb.org/node_modules/.pnpm/astro@4.2.1_@types+node@20.11.5_typescript@5.3.3/node_modules/astro/dist/core/build/generate.js:141:11)
 ELIFECYCLE  Command failed with exit code 1.

I didn't have time to investigate tonight, wondering if @cyyynthia you have any idea off the top of your head what might be the issue here.

cyyynthia commented 7 months ago

Hi there, first off thanks for looking into that and contributing to PronounDB!

I haven't gotten around to reviewing the code yet, but I'll let you know right off that I'm unsure about how i18n will go and there are a few things in the current structure I want to change, like the way text is rendered when "any" is involved. I wrote this on my Discord server which is still relevant:

Screenshot_20240207-085520.png

I want you to know that right off so you don't burn some of your time on it when there's a chance it'll stay on the shelf collecting dust until things are a bit clearer for me in terms of the direction this thing should go 😅

Regarding your issues, did you setup a .env file in packages/website?

NoPlagiarism commented 7 months ago

I want you to know that right off so you don't burn some of your time on it when there's a chance it'll stay on the shelf collecting dust until things are a bit clearer for me

What about adding new FAQ section?