search

cyyynthia / pronoundb.org

A browser extension that lets people know how to refer to each other on various places of the Internet. Available on Chrome, Firefox, and Edge.
https://pronoundb.org
BSD 3-Clause "New" or "Revised" License
271 stars 22 forks source link

fix(docs): fix capitalize parameter for shields #110

Closed qtlunya closed 6 months ago

qtlunya commented 6 months ago

I tested it and it needs to be ?capitalize=true, not simply ?true.

cyyynthia commented 6 months ago

Hm that's a good catch; I initially wrote it that way because I intended it to mean that you need to use ....json?capitalize for it to be capitalized, but in retrospect yeah that is kind of confusing and seem to indicate you just have to put true 😅

The .json?capitalize= can be a single string instead of 2 parts; plus right now they'd concatenate to ?&

qtlunya commented 6 months ago

I tried just ?capitalize now, that doesn't seem to do it either, but ?capitalize=true works. (?capitalize= with an equals sign also works.)

Updated the PR to make it a single string.

cyyynthia commented 6 months ago

Seem to be working: https://pronoundb.org/shields/5fd62c00985db32c8e80d5b6.json?capitalize

Either way it's cleaner to have the explicit bool, so I'll merge this. Thanks!