search

cyyynthia / pronoundb.org

A browser extension that lets people know how to refer to each other on various places of the Internet. Available on Chrome, Firefox, and Edge.
https://pronoundb.org
BSD 3-Clause "New" or "Revised" License
271 stars 22 forks source link

fix(twitter): tweet pronoun color #115

Closed busybox11 closed 5 months ago

busybox11 commented 5 months ago

before fix:

image

with fix:

image
cyyynthia commented 5 months ago

The code in master currently doesn't have this issue and it has already been fixed. I've haven't published it yet because I wanted to get decorations for Twitter ready & out of beta but there are still some annoying edge cases I haven't been able to solve (Your own screenshot is a good example of that!), and I haven't had time to work on it much lately... 😔

If master code hasn't it fixed, then I just have the fix locally and didn't push it yet - but that's effectively the same thing: already fixed, not yet released.

I'll try to make a release later this week with just the fixes. Thanks for the PR though!

busybox11 commented 5 months ago

Ah, that's okay. Waiting for your push then, in the meantime I'm using my own build to fix it locally. It wasn't a useless change anyway haha.

cyyynthia commented 5 months ago

The fix was indeed only present in my local repository. Fixed in commit 3e6ff2e2356661dedd3bd736f459b9ec66d10c8e.