search

cyyynthia / pronoundb.org

A browser extension that lets people know how to refer to each other on various places of the Internet. Available on Chrome, Firefox, and Edge.
https://pronoundb.org
BSD 3-Clause "New" or "Revised" License
271 stars 21 forks source link

Firefox permissions #38

Closed AliceDTRH closed 2 years ago

AliceDTRH commented 2 years ago

I noticed the extension now requires access to all tabs on Firefox. I was wondering why this was needed but I couldn't find the commit where it was changed. Could you point me in the right direction?

Kind regards, Alice

cyyynthia commented 2 years ago

Hello,

The tabs permission change was introduced early in the extension rewrite and is used only here.

The extension uses URLs to determine whether it should load an integration or not, and this also applies for the popout screen. Unfortunately for principle of least privilege, getting the URL of the currently selected tab (or any tab for that matter) in a popout requires the tabs permission which is rather broad sadly.

cyyynthia commented 2 years ago

Actually, looking back at the docs it seems I completely overlooked the activeTab permission, whoops!

I'll loosen the permission requirements and publish a new version shortly.

cyyynthia commented 2 years ago

The new version of the extension (0.6.1) should go live on AMO shortly. Thanks for the heads up!

AliceDTRH commented 2 years ago

Thank you :)