"G" and "4" at text width 4 breaks mesh

czM1K3 / keychain-generator

Basic web app that lets you generate basic keychains that are printable on 3D printer.

https://keychain-generator.vercel.app

MIT License

8 stars 7 forks source link

"G" and "4" at text width 4 breaks mesh #4

Open funkonaut opened 2 years ago

funkonaut commented 2 years ago

When generating a keychain with only the letter G or the number 4 the model will have unwanted holes in it

funkonaut commented 2 years ago

Getting rid of the union of the 2D text's line segments in the buildFlatText function seems to resolve this issue. Not sure if that union is necessary, tested with variety of input and seems to still perform the same as before, but fixes the weird mesh issues with G and 4 at a text width of 4. Submitted PR

czM1K3 commented 1 year ago

I think this would be fixable with custom font. I have seen this error on OpenJSCAD issue. More on that at #16.